Skip to content

Conversation

@jmcarlock
Copy link
Contributor

@jmcarlock jmcarlock commented Aug 20, 2024

Proposed commit message

Adds fields/custom.yml files back to the DGA and Living off the Land (ProblemChild) integration packages. These files are used for integration testing done upstream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs. Not needed
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Test with elastic-package

How to test this PR locally

Build with elastic-package.

Related issues

@jmcarlock jmcarlock added the bugfix Pull request that fixes a bug issue label Aug 20, 2024
@jmcarlock jmcarlock self-assigned this Aug 20, 2024
@andrewkroh andrewkroh added Integration:dga Domain Generation Algorithm Detection Integration:problemchild Living off the Land Attack Detection labels Aug 20, 2024
@susan-shu-c
Copy link
Member

Thanks Gus! In this PR description, can you also link the PRs where the files were previously removed, for documentation purposes?

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @jmcarlock

@elastic-sonarqube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@jmcarlock
Copy link
Contributor Author

@jmcarlock
Copy link
Contributor Author

  • Low coverage on SonarQube is a known issue for these packages, e.g. from this previous PR.
  • The yaml files in the fields directories are only used for integration package testing and not for actually providing mappings for these fields. This was not clear with the previous PR, thank you @shashank-elastic !
@jmcarlock jmcarlock marked this pull request as ready for review August 20, 2024 20:02
@jmcarlock jmcarlock requested review from a team as code owners August 20, 2024 20:02
@jmcarlock jmcarlock merged commit 5589950 into main Aug 20, 2024
@jmcarlock jmcarlock deleted the fix-detection-rules-tests branch August 20, 2024 20:02
@jmcarlock
Copy link
Contributor Author

Thank you @susan-shu-c @sodhikirti07 @qn895 for the quick review!

@elasticmachine
Copy link

Package dga - 2.0.4 containing this change is available at https://epr.elastic.co/search?package=dga

@elasticmachine
Copy link

Package problemchild - 2.1.5 containing this change is available at https://epr.elastic.co/search?package=problemchild

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
* Add back custom.yml files to LotL, DGA packages * add to changelog, bump package manifest version * add `base-fields.yml` to pass tests
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
* Add back custom.yml files to LotL, DGA packages * add to changelog, bump package manifest version * add `base-fields.yml` to pass tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:dga Domain Generation Algorithm Detection Integration:problemchild Living off the Land Attack Detection

7 participants