[fortinet_fortigate] add hostname parsing for syslog #11678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 💚 CLA has been signed |
andrewkroh added Integration:fortinet_fortigate 
| Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
andrewkroh added bugfix Contributor
taylor-swanson left a comment
taylor-swanson left a comment There was a problem hiding this comment.
Some minor changes, but otherwise seems good to me.
The top-level manifest version needs to be updated as well:
manifest.yml:
- version: "1.26.0" + version: "1.27.0" packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
Nacon96 commented Nov 11, 2024
Contributor Author
Nacon96 left a comment
Nacon96 left a comment There was a problem hiding this comment.
i see the changes adequate, thanks.
taylor-swanson requested changes Nov 12, 2024
Contributor
taylor-swanson left a comment
taylor-swanson left a comment There was a problem hiding this comment.
In case I wasn't clear, the changes I requested are ones I'm requiring.
- For how we use semver, any additional fields added require at least a
minorchange to versioning. Patch versions are reserved for bugfixes/enhancements that don't alter the structure of documents, among other things. - We don't need to set fields from a grok only to not use them and only remove them later. This just adds unnecessary actions to the pipeline.
…st_pipeline/default.yml Co-authored-by: Taylor Swanson <90622908+taylor-swanson@users.noreply.github.com>
Co-authored-by: Taylor Swanson <90622908+taylor-swanson@users.noreply.github.com>
…st_pipeline/default.yml Co-authored-by: Taylor Swanson <90622908+taylor-swanson@users.noreply.github.com>
…st_pipeline/default.yml Co-authored-by: Taylor Swanson <90622908+taylor-swanson@users.noreply.github.com>
Contributor
taylor-swanson left a comment
taylor-swanson left a comment There was a problem hiding this comment.
Updated changes LGTM, we just need to bump the version in the manifest.
packages/fortinet_fortigate/manifest.yml
- version: "1.26.0" + version: "1.27.0"
Contributor
| /test |
andrewkroh added enhancement 
Member
I pushed this change. And aligned the changelog to use |
Contributor
| /test |
taylor-swanson approved these changes Dec 6, 2024
🚀 Benchmarks reportTo see the full report comment with |
|
💚 Build Succeeded
History
|
| Package fortinet_fortigate - 1.27.0 containing this change is available at https://epr.elastic.co/package/fortinet_fortigate/1.27.0/ |
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
- The current parser is not processing the hostname field of syslog messages, so in some cases, the observer.name field remains empty. Added support for parsing out the hostname field of syslog messages and placing it into the observer.name field. --------- Co-authored-by: Taylor Swanson <90622908+taylor-swanson@users.noreply.github.com> Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
- The current parser is not processing the hostname field of syslog messages, so in some cases, the observer.name field remains empty. Added support for parsing out the hostname field of syslog messages and placing it into the observer.name field. --------- Co-authored-by: Taylor Swanson <90622908+taylor-swanson@users.noreply.github.com> Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The current parser is not processing the hostname field of syslog messages, so in some cases, the
observer.namefield remains empty.Checklist
changelog.ymlfile.