Skip to content

Conversation

@harnish-crest-data
Copy link
Contributor

@harnish-crest-data harnish-crest-data commented Jan 8, 2025

  • Bugfix

Proposed commit message

  • Fix error handling mechanism in alert, mongod_audit, mongod_database, organization and project data streams
  • Update data type from object to flattened for mongod_audit.param and mongod_database.attributes fields to prevent data conflict/loss.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

Screenshot

Before
image (11)

After
image

@harnish-crest-data harnish-crest-data added Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] bugfix Pull request that fixes a bug issue Integration:mongodb_atlas MongoDB Atlas labels Jan 8, 2025
@harnish-crest-data harnish-crest-data self-assigned this Jan 8, 2025
@harnish-crest-data harnish-crest-data marked this pull request as ready for review January 8, 2025 06:36
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner January 8, 2025 06:36
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jan 8, 2025

🚀 Benchmarks report

Package mongodb_atlas 👍(2) 💚(1) 💔(5)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
disk 12195.12 8695.65 -3499.47 (-28.7%) 💔
hardware 15151.52 10638.3 -4513.22 (-29.79%) 💔
mongod_database 22222.22 12987.01 -9235.21 (-41.56%) 💔
process 2298.85 1862.2 -436.65 (-18.99%) 💔
project 4629.63 2227.17 -2402.46 (-51.89%) 💔

To see the full report comment with /test benchmark fullreport

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal of this is to give better error message. Right ?
The customer will still observe the error as shown in the SDH. This makes them make better sense of the error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal of this is to give better error message. Right ?

Yes

The customer will still observe the error as shown in the SDH. This makes them make better sense of the error.

If the body == null then they will get the http status codes as well http status! If the response body exists then they will get body details and error code!

@harnish-crest-data harnish-crest-data force-pushed the mongodb_atlas-resolve-drop-event branch from 45a3b29 to 65cddbd Compare January 27, 2025 06:26
@elastic-sonarqube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
34.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #20171 succeeded cf50ff5c1bd3f2029472fd71bbcc32ce9ab780c8
  • 💚 Build #20167 succeeded ea1b799c897bf41df88715e8e74fb6167885e5bc
  • 💚 Build #20136 succeeded 56fe3152c556a6ef1e54fc71f99cd33ffd066c5c

cc @harnish-elastic

Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@harnish-crest-data harnish-crest-data merged this pull request into elastic:main Jan 28, 2025
4 of 5 checks passed
@elastic-vault-github-plugin-prod

Package mongodb_atlas - 0.1.2 containing this change is available at https://epr.elastic.co/package/mongodb_atlas/0.1.2/

harnish-crest-data added a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…udit, mongod_database, organization and project data streams as well update data type from object to flattened for mongod_audit.param and mongod_database.attributes fields to prevent data conflict/loss (elastic#12257) * Fix error handling mechanism in alert, mongod_audit, mongod_database, organization and project data streams. Update data type from object to flattened for mongod_audit.param and mongod_database.attributes fields to prevent data conflict/loss * update pr link * cel code formatting * update code if there are no data in given time period error resolve * tested negative scenarios and resolve issue related to pipeline * address review comments
harnish-crest-data added a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…udit, mongod_database, organization and project data streams as well update data type from object to flattened for mongod_audit.param and mongod_database.attributes fields to prevent data conflict/loss (elastic#12257) * Fix error handling mechanism in alert, mongod_audit, mongod_database, organization and project data streams. Update data type from object to flattened for mongod_audit.param and mongod_database.attributes fields to prevent data conflict/loss * update pr link * cel code formatting * update code if there are no data in given time period error resolve * tested negative scenarios and resolve issue related to pipeline * address review comments
@harnish-crest-data harnish-crest-data deleted the mongodb_atlas-resolve-drop-event branch February 7, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:mongodb_atlas MongoDB Atlas Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

3 participants