Skip to content

SSI Integration: Use terminate processor instead of fail and update the kibana constraint to ^8.16.0 #14461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 11, 2025
Merged

SSI Integration: Use terminate processor instead of fail and update the kibana constraint to ^8.16.0 #14461

merged 6 commits into from
Jul 11, 2025

Conversation

@brijesh-elastic
Copy link
Collaborator

@brijesh-elastic brijesh-elastic commented Jul 9, 2025 •
edited
Loading

Proposed commit message

SSI Integration: Use terminate processor instead of fail and update the kibana constraint to ^8.16.0 This will utilize the `terminate` processor instead of the `fail` processor, as the `fail` processor introduces an unwanted side effect by creating an additional `error.message` value. Upgrade the `format_version` to latest 3.4.0 Upgrade the kibana constraint to ^8.16.0

Note

  • Due to the lack of live data or an instance, I haven't populated or tested the dashboards. (However, I did have an instance for Sysdig and populated dashboards for it, which are working as expected.)

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues
@brijesh-elastic brijesh-elastic self-assigned this Jul 9, 2025
@brijesh-elastic brijesh-elastic requested a review from a team as a code owner July 9, 2025 07:18
@brijesh-elastic brijesh-elastic added enhancement New feature or request dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:github GitHub Integration:mimecast Mimecast (Partner supported) Integration:ti_opencti OpenCTI Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] mapping/pipeline issue Integration:digital_guardian Digital Guardian Integration:authentik authentik Integration:spycloud SpyCloud Enterprise Protection (Partner supported) Integration:first_epss First EPSS (Community supported) Integration:claroty_ctd Claroty CTD Integration:sysdig Sysdig Integration:ti_custom Custom Threat Intelligence Integration:checkpoint_email Check Point Harmony Email & Collaboration Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] Integration:armis Armis labels Jul 9, 2025
@elasticmachine
Copy link

elasticmachine commented Jul 9, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 9, 2025 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
kcreddy
kcreddy reviewed Jul 9, 2025
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look into the CI error for authentik inside static tests?

test case failed: one or more errors found in document: [0] field "source.geo.location.coordinates" is undefined, could be a multifield
[1] field "source.geo.location.type" is undefined, could be a multifield
kcreddy
kcreddy reviewed Jul 9, 2025
View reviewed changes
packages/armis/manifest.yml
@@ -1,7 +1,7 @@
format_version: 3.3.2
format_version: 3.4.0
Copy link
Contributor

@kcreddy kcreddy Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message says format_version as latest 8.4.0 instead should be 3.4.0
@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 9, 2025
efd6
efd6 reviewed Jul 9, 2025
View reviewed changes
packages/authentik/changelog.yml Outdated
Comment on lines 7 to 9
- description: Update the kibana constraint to ^8.16.0.
type: enhancement
link: https://github.com/elastic/integrations/pull/14461
Copy link
Contributor

@efd6 efd6 Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that we need to include this in the changelog; it gets reflected in availability in the integrations addition page by the filter.
Copy link
Collaborator Author

@brijesh-elastic brijesh-elastic Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I'll remove it.
packages/checkpoint_email/changelog.yml Outdated
Comment on lines 7 to 9
- description: Update the kibana constraint to ^8.16.0.
type: enhancement
link: https://github.com/elastic/integrations/pull/14461
Copy link
Contributor

@efd6 efd6 Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above (and all below that I've not yet seen).
kcreddy
kcreddy approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM for my comments.
@brijesh-elastic brijesh-elastic requested a review from efd6 July 10, 2025 07:19
efd6
efd6 approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
@elasticmachine
Copy link

elasticmachine commented Jul 11, 2025

💚 Build Succeeded

History

cc @brijesh-elastic
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Jul 11, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
95.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@efd6 efd6 merged commit 60d399f into elastic:main Jul 11, 2025
9 checks passed
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 11, 2025

Package armis - 0.3.0 containing this change is available at https://epr.elastic.co/package/armis/0.3.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 11, 2025

Package authentik - 1.5.0 containing this change is available at https://epr.elastic.co/package/authentik/1.5.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 11, 2025

Package checkpoint_email - 1.1.0 containing this change is available at https://epr.elastic.co/package/checkpoint_email/1.1.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 11, 2025

Package claroty_ctd - 1.1.0 containing this change is available at https://epr.elastic.co/package/claroty_ctd/1.1.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 11, 2025

Package digital_guardian - 1.7.0 containing this change is available at https://epr.elastic.co/package/digital_guardian/1.7.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 11, 2025

Package first_epss - 1.1.0 containing this change is available at https://epr.elastic.co/package/first_epss/1.1.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 11, 2025

Package github - 2.10.0 containing this change is available at https://epr.elastic.co/package/github/2.10.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 11, 2025

Package mimecast - 3.1.0 containing this change is available at https://epr.elastic.co/package/mimecast/3.1.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 11, 2025

Package spycloud - 1.5.0 containing this change is available at https://epr.elastic.co/package/spycloud/1.5.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 11, 2025

Package sysdig - 1.1.0 containing this change is available at https://epr.elastic.co/package/sysdig/1.1.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 11, 2025

Package ti_custom - 1.2.0 containing this change is available at https://epr.elastic.co/package/ti_custom/1.2.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 11, 2025

Package ti_opencti - 2.7.0 containing this change is available at https://epr.elastic.co/package/ti_opencti/2.7.0/
@brijesh-elastic brijesh-elastic mentioned this pull request Jul 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard Relates to a Kibana dashboard bug, enhancement, or modification. documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:armis Armis Integration:authentik authentik Integration:checkpoint_email Check Point Harmony Email & Collaboration Integration:claroty_ctd Claroty CTD Integration:digital_guardian Digital Guardian Integration:first_epss First EPSS (Community supported) Integration:github GitHub Integration:mimecast Mimecast (Partner supported) Integration:spycloud SpyCloud Enterprise Protection (Partner supported) Integration:sysdig Sysdig Integration:ti_custom Custom Threat Intelligence Integration:ti_opencti OpenCTI mapping/pipeline issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]

5 participants

@brijesh-elastic @elasticmachine @kcreddy @efd6 @andrewkroh