[gcp] Update DNS Logs #2340
Merged
[gcp] Update DNS Logs #2340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
legoguy1000 force-pushed the gcp-dns-public-query-logs branch from 66f4d1a to 82368ef Compare 
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Contributor Author
| @kaiyan-sheng could you run tests for this too? |
Contributor
| /test |
legoguy1000 force-pushed the gcp-dns-public-query-logs branch 3 times, most recently from 5a13d7a to eb0c6ad Compare Contributor Author
| OK, i think it should be fixed now. |
legoguy1000 force-pushed the gcp-dns-public-query-logs branch from eb0c6ad to ae69047 Compare Contributor Author
| @kaiyan-sheng can we rerun tests on this? |
Contributor
| /test |
| Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Contributor
| This needs to have the version bumped in manifest.yml. |
efd6 reviewed Feb 4, 2022
packages/gcp/data_stream/dns_public_logs/_dev/test/pipeline/test-common-config.yml Outdated Show resolved Hide resolved
packages/gcp/data_stream/dns_public_logs/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/gcp/data_stream/dns_public_logs/_dev/test/pipeline/test-dns.log-expected.json Outdated Show resolved Hide resolved
Contributor Author
| fixes pushed. |
legoguy1000 force-pushed the gcp-dns-public-query-logs branch from 945724f to 58b4098 Compare Contributor
| /test |
1 similar comment
Contributor
| /test |
legoguy1000 force-pushed the gcp-dns-public-query-logs branch from aeeaedf to f544ceb Compare 
andrewkroh changed the title legoguy1000 force-pushed the gcp-dns-public-query-logs branch from 864e30b to 84a3eb0 Compare Contributor Author
| I rebased and merged the datastreams should be GTG. |
Contributor
| /test |
🌐 Coverage report
|
legoguy1000 changed the title legoguy1000 force-pushed the gcp-dns-public-query-logs branch from 78f8eee to 3fc2931 Compare Contributor
| /test |
efd6 reviewed Jul 25, 2022
packages/gcp/data_stream/dns/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/gcp/data_stream/dns/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/gcp/data_stream/dns/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
Contributor Author
| @efd6 comments addressed |
Contributor
| /test |
efd6 approved these changes Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enhances the log enrichment/normalization for GCP DNS logs.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots