- Notifications
You must be signed in to change notification settings - Fork 515
[docs] Add context to AWS integration documentation #3308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add context to AWS integration documentation #3308
Conversation
🌐 Coverage report
|
bmorelli25 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
Side note: The md style comments <!-- Example ?? --> break the doc build. The mdx style comment is {/* this is a comment */}, which doesn't work in markdown (of course). They're fine for now, just pointing it out.
update generated docs
28d4c3d to c0abc2d Compare | ping @elastic/obs-cloud-monitoring |
| Hi @colleenmcginnis thanks for making the changes! Quick question, are we planning to make the same change for CloudFront to all the other integrations under AWS? |
kaiyan-sheng left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zmoog left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, no more nits; I love the changes you made.
What does this PR do?
From https://github.com/elastic/observability-docs/issues/1019:
This PR adds more context the AWS integration including:
For the reviewer:
Checklist
changelog.ymlfile.Author's Checklist
Related issues