Skip to content

[GCP] Add GKE data stream #4098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 31, 2022
Merged

[GCP] Add GKE data stream #4098

merged 4 commits into from
Aug 31, 2022

Conversation

@gpop63
Copy link
Contributor

@gpop63 gpop63 commented Aug 30, 2022

What does this PR do?

Adds gke data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@gpop63 gpop63 added Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Aug 30, 2022
@elasticmachine
Copy link

elasticmachine commented Aug 30, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-31T09:51:25.629+0000

  • Duration: 18 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 78
Skipped 0
Total 78

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

elasticmachine commented Aug 30, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 2.655
Classes 100.0% (5/5) 💚 2.655
Methods 92.391% (85/92) 👍 2.516
Lines 95.752% (1375/1436) 👍 5.018
Conditionals 100.0% (0/0) 💚
@gpop63 gpop63 marked this pull request as ready for review August 30, 2022 11:05
@gpop63 gpop63 requested review from a team as code owners August 30, 2022 11:05
endorama
endorama approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 small enhancements to the docs, everything else looks good to me!
@endorama
Copy link
Contributor

endorama commented Aug 31, 2022

@gpop63 feel free to merge this once the CI is green!
@gpop63 gpop63 merged commit bafdd2a into elastic:main Aug 31, 2022
@andrewkroh andrewkroh mentioned this pull request Sep 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team

3 participants

@gpop63 @elasticmachine @endorama