Skip to content

[auditd_manager] Add audit rule files option to auditd_manager #4905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 3, 2023
Merged

[auditd_manager] Add audit rule files option to auditd_manager #4905

merged 3 commits into from
Jan 3, 2023

Conversation

@marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Dec 28, 2022

What does this PR do?

Adds the audit_rule_files option.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@marc-gr marc-gr requested a review from a team as a code owner December 28, 2022 14:32
@elasticmachine
Copy link

elasticmachine commented Dec 28, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@elasticmachine
Copy link

elasticmachine commented Dec 28, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-03T08:42:29.034+0000

  • Duration: 14 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 21
Skipped 0
Total 21

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

elasticmachine commented Dec 28, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 88.889% (8/9) 👍 22.222
Lines 90.404% (179/198) 👎 -9.596
Conditionals 100.0% (0/0) 💚
kcreddy
kcreddy reviewed Dec 29, 2022
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need some clarifications. Rest LGTM 👍🏼
@marc-gr marc-gr requested a review from kcreddy January 3, 2023 08:42
kcreddy
kcreddy approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
@marc-gr marc-gr merged commit bdd2b7e into elastic:main Jan 3, 2023
@marc-gr marc-gr deleted the audit_manager/audit_rule_files branch January 3, 2023 09:03
@elasticmachine
Copy link

elasticmachine commented Jan 3, 2023

Package auditd_manager - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=auditd_manager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

3 participants

@marc-gr @elasticmachine @kcreddy