Skip to content

Conversation

@constanca-m
Copy link
Contributor

What does this PR do?

Add metric type to natgateway data stream fields, necessary to support TSDB in the future.

Details

Gauge and counter fields were defined based on:

  1. The metrics that represent a specific value in time, without consideration for the previous one, are gauge.
  2. If a metric keeps increment and decrementing, it is a gauge.
  3. If a metric is cumulative, then it is a counter - but it can only increment.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Refer to #6101

Related issues

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m requested a review from a team as a code owner May 5, 2023 09:50
@constanca-m constanca-m self-assigned this May 5, 2023
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@elasticmachine
Copy link

elasticmachine commented May 5, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-22T08:58:03.786+0000

  • Duration: 47 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 4
Total 192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 5, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -1.25
Classes 93.75% (15/16) 👎 -1.25
Methods 86.131% (236/274) 👎 -1.689
Lines 85.925% (7387/8597) 👎 -0.542
Conditionals 100.0% (0/0) 💚
@constanca-m constanca-m merged commit c3c694a into elastic:main May 22, 2023
@constanca-m constanca-m deleted the nat-add-metrics branch May 22, 2023 09:46
@elasticmachine
Copy link

Package aws - 1.36.6 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants