Skip to content

Conversation

@P1llus
Copy link
Member

@P1llus P1llus commented Mar 9, 2021

What does this PR do?

This PR removes the edge processing from the package and bumping the version. It also restrict it to a new minimum version due to the addition of the community_id ingest pipeline processor requiring it.

The PR also adds some new fields to the package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Related issues

…lso adding in new test data and bumping version
@P1llus P1llus requested a review from adriansr March 9, 2021 09:37
@P1llus P1llus added enhancement New feature or request Integration:panw Palo Alto Next-Gen Firewall labels Mar 9, 2021
"forwarded"
],
"message": "Oct 30 09:46:12 1,2012/10/30 09:46:12,01606001116,TRAFFIC,start,1,2012/04/10 04:39:58,192.168.0.2,204.232.231.46,0.0.0.0,0.0.0.0,rule1,crusher,,web-browsing,vsys1,trust,untrust,ethernet1/2,ethernet1/1,forwardAll,2012/04/10 04:39:59,11449,1,59324,80,0,0,0x200000,tcp,allow,78,78,0,1,2012/04/10 04:39:59,0,any,0,0,0x0,192.168.0.0-192.168.255.255,United States,0,1,0",
"event": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This event seems to not be parsed now, is this intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason it is removed, is because when running pipeline tests, it won't use the edge processing, so you had to prepare a raw document that had all the edge-processing applied.

This was now removed since there is no edge processing anymore. Please compare with the *-expected.json

@P1llus
Copy link
Member Author

P1llus commented Mar 9, 2021

The old pipeline did not support all test messages, it only parses TRAFFIC and THREAT, I plan to add the rest of the logfile in a separate PR, as it would be too large for a single one. There is also a community PR ongoing to add parsing for more, which I also plan to implement here separately, so any testlogs that does not have TRAFFIC or THREAT type will not be handled at the moment, and that is the same behavior as before the removal of edge-processing.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@P1llus P1llus requested a review from andrewkroh March 9, 2021 15:49
@P1llus
Copy link
Member Author

P1llus commented Mar 10, 2021

jenkins run tests please

Copy link
Contributor

@marc-gr marc-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link

elasticmachine commented Mar 12, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2021-03-22T22:28:20.456+0000

  • Duration: 92 min 20 sec

  • Commit: 41e523f

Test stats 🧪

Test Results
Failed 0
Passed 1918
Skipped 3
Total 1921

Trends 🧪

Image of Build Times

Image of Tests

@P1llus P1llus merged commit b6a86b2 into elastic:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:panw Palo Alto Next-Gen Firewall

4 participants