Skip to content

Build apache integration #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 29, 2020
Merged

Build apache integration #98

merged 14 commits into from
Jun 29, 2020

Conversation

@mtojek
Copy link
Contributor

@mtojek mtojek commented Jun 23, 2020 •
edited
Loading

This PR migrates apache modules to the integration.

Screenshots:

Zrzut ekranu 2020-06-24 o 12 22 11

Zrzut ekranu 2020-06-23 o 12 24 45

screencapture-localhost-5601-app-dashboards-2020-06-24-12_00_50

screencapture-localhost-5601-app-dashboards-2020-06-24-12_20_08
@mtojek mtojek self-assigned this Jun 23, 2020
@elasticmachine
Copy link

elasticmachine commented Jun 23, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-06-27T17:24:21.067+0000

  • Duration: 4 min 4 sec
@mtojek
Copy link
Contributor Author

mtojek commented Jun 23, 2020

Currently blocked by: elastic/kibana#69677
@mtojek mtojek added the Team:Integrations Label for the Integrations team label Jun 24, 2020
@mtojek mtojek marked this pull request as ready for review June 24, 2020 10:23
@mtojek
Copy link
Contributor Author

mtojek commented Jun 24, 2020

The integration is finished. All dashboards are presenting data.

@ruflin few questions here:

  1. Under which version should I release the package?
  2. I marked it as release: beta, so once I merge this PR it will be released to public. Is it ok?
@ruflin
Copy link
Contributor

ruflin commented Jun 25, 2020

  • Version: As it is still in beta, I would pick something 0.*.0. I see the others are in 0.1.0 so this is probably a good pick
  • Beta: Yes, we want to have this in 7.9.
@mtojek mtojek added Team:Integrations Label for the Integrations team and removed Team:Integrations Label for the Integrations team labels Jun 26, 2020
@elasticmachine
Copy link

elasticmachine commented Jun 26, 2020

Pinging @elastic/integrations (Team:Integrations)
exekias
exekias reviewed Jun 29, 2020
View reviewed changes
packages/nginx/manifest.yml
show_user: true
default:
- http://127.0.0.1
- http://127.0.0.1:80
Copy link

@exekias exekias Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change intended?
Copy link
Contributor Author

@mtojek mtojek Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intended to slightly suggest that it's possible to configure a port. I can clean this one if it's better.
exekias
exekias approved these changes Jun 29, 2020
View reviewed changes
Copy link

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question on the NGINX change but this LGTM
@mtojek mtojek merged commit 41edc39 into elastic:master Jun 29, 2020
@andrewkroh andrewkroh added Integration:apache Apache HTTP Server Integration:nginx Nginx New Integration Issue or pull request for creating a new integration package. labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:apache Apache HTTP Server Integration:nginx Nginx New Integration Issue or pull request for creating a new integration package. Team:Integrations Label for the Integrations team

5 participants

@mtojek @elasticmachine @ruflin @exekias @andrewkroh