Add execution block hashes in chain reorg SSE#585
Draft
bharath-123 wants to merge 1 commit intoethereum:masterfrom
Draft
Add execution block hashes in chain reorg SSE#585bharath-123 wants to merge 1 commit intoethereum:masterfrom
bharath-123 wants to merge 1 commit intoethereum:masterfrom
Conversation
Contributor
| This approach is similar to option 3 from: |
Member
I am not in favor of option 3. there but I think adding new fields to this event is fine as they are distinct from existing fields. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With gloas, there can be a payload reorg where the beacon block stays the same but the payload associated with the block changes.
It might make sense to add the old and new execution block hashes of the head blocks in the chain_reorg event