core: tx pool skip price validation for "owned" transactions

[zsfelfoldi]

Add "local" parameter for adding transactions which circumvents gas price checking against local miner minimum

[robotally]

Vote	Count	Reviewers
👍	2	@obscuren @zelig
👎	0

Updated: Wed Dec 16 15:14:48 UTC 2015

[codecov-io]

Current coverage is 43.79%

Merging #1997 into develop will increase coverage by +0.01% as of 4346ab7

Powered by Codecov. Updated on successful CI builds.

[alexvandesande]

👏🏻👏🏻👏🏻 Extremely needed!

[karalabe]

Maybe consider instead providing a local bool flag to AddTransactions? I'm not sure we need to separate method calls for it. Similarly, if the old one is AddTransactions, a new version should be AddLocalTransactions (note, plural) to keep the naming and parametrization consistent.

Edit: Maintaining a single method would also solve the issue that you didn't write any error handling :P (logs, etc).

[obscuren]

👎 Please go with the single method approach and add some tests for this newly created behaviour.

[alexvandesande]

@obscuren what do you mean by "single method approach"?

[obscuren]

@alexvandesande AddLocal(tx) vs Add(tx, local)

[zsfelfoldi]

Locality of a transaction is now marked in a map instead of passing a flag when adding the transaction. The reason for this is that transactions are sometimes put back into the tx pool when reorganizing chain so we need to remember which one was local.
Still need to add some tests and remove old entries from the map.

[zsfelfoldi]

ready for review

[obscuren]

Please squash and format commit

[obscuren]

👍

[bas-vk]

@zsfelfoldi, could you rebase and add this line in the new RPC method since XEth will be removed?
Location is eth/api.go.

Should this line also be added to the sendRawTransaction?

[zsfelfoldi]

@bas-vk done, added it to sendRawTransaction too. I think you're right about that, a raw transaction might have been signed somewhere else but if a local application intends to add it then the local client should always accept it.

[zelig]

👍 LGTM