test: enhance req.is() tests with additional cases #6703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
| @@ -1,7 +1,8 @@ | |||
| 'use strict' | |||
| | |||
| var express = require('..') | |||
There was a problem hiding this comment.
Suggested change
| var express = require('..') | |
| const express = require('..') |
| 'use strict' | ||
| | ||
| var express = require('..') | ||
| var request = require('supertest') |
There was a problem hiding this comment.
Suggested change
| var request = require('supertest') | |
| const request = require('supertest') |
| | ||
| var express = require('..') | ||
| var request = require('supertest') | ||
| var after = require('after') |
There was a problem hiding this comment.
Suggested change
| var after = require('after') | |
| const after = require('after') |
// in modern JS is better to use const instead of var!
hamidrezaghavami left a comment
hamidrezaghavami left a comment There was a problem hiding this comment.
your code was so structured, I mainly review it for learning purposes, well done!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Basically, we support an array as an argument for req.is. This hasn’t been documented, and we should document it on the website.
Ref:
express/lib/request.js
Line 260 in 8f21493