Open
Conversation
added 2 commits December 9, 2022 17:19
thefad3d commented Dec 10, 2022
Author
thefad3d left a comment
thefad3d left a comment There was a problem hiding this comment.
I notice the tabbing has changed in gen_windows_chrome_known_settings.rb after running windows_policy_gen.rb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR regenerates the contents of
itchef/cookbooks/cpe_chrome/libraries/gen_windows_chrome_known_settings.rbby re-importing the contents ofitchef/cookbooks/cpe_chrome/scripts/win_chrome_policy.regfrom https://chromeenterprise.google/browser/download/#manage-policies-tabDoes this PR introduce a user-facing change?:
NONEAdditional documentation e.g., Design Proposals, usage docs, etc.: