add react-testing-library documentation/examples #4679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Thanks! Small nit, fix "assertsions". |
Contributor Author
| Done 👍 |
Contributor
| Awesome! |
Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018
* add react-testing-library documentation/examples * make react-testing-library a heading * fix typo
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Aug 14, 2018
* add react-testing-library documentation/examples * make react-testing-library a heading * fix typo
cloud-walker pushed a commit to cloud-walker/create-react-app that referenced this pull request Aug 27, 2018
* Add modes to our Babel preset (1.x) (facebook#4668) * babel-preset-react-app@3.1.2 * add react-testing-library documentation/examples (facebook#4679) * add react-testing-library documentation/examples * make react-testing-library a heading * fix typo * Fix link to the article about BEM (facebook#4858) * Use file name whitelist to prevent RCE (facebook#4866) * Use file name whitelist to prevent RCE Use a whitelist to validate user-provided file names. This doesn't cover the entire range of valid filenames but should cover almost all of them in practice. Allows letters, numbers, periods, dashes, and underscores. Opting to use a whitelist instead of a blacklist because getting this wrong leaves us vulnerable to a RCE attack. * Allow alphabet characters from all languages Updated the whitelist to /^[\p{L}0-9/.\-_]+$/u, which matches alphanumeric characters, periods, dashes, and underscores. Unicode property support is stage 4 so I've inlined the transpiled version. * Only use file name whitelist on Windows * Log error message if file name does not pass whitelist * Bump versions * Bump release * Add 1.1.5 release notes
Contributor
| This is lost somehow now. Not present in master anymore :( |
Contributor
| No clue where it went. Can someone resubmit please? |
Contributor
| I'm pretty sure it was in this merge commit: 4562ab6 I'll create a new PR to add it back. |
Contributor
| Ah, I didn't realize this was merged into |
Timer pushed a commit that referenced this pull request Oct 4, 2018
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018
…ebook#5290) * add react-testing-library documentation/examples * make react-testing-library a heading * fix typo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Rendered: https://github.com/kentcdodds/create-react-app/blob/1b3a028f0dea697322a2e85906c7642f357313c6/packages/react-scripts/template/README.md#use-react-testing-library
Considering the growing popularity of react-testing-library, it seems fitting to document and provide examples of using this library for folks looking for a testing utility that matches their preferences.