The need for relative public path (to the endpoint, not hostname) in the production build #931
Conversation
User story: I want to publish my app on, for example, Github Pages and I want to leave PUBLIC_URL as a default due to possibility of change of the endpoint url or share the build between several endpoints.
| Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
lexfrl changed the title lexfrl changed the title lexfrl changed the title 
| Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| Thanks for the PR, but AFAIK this breaks We don't officially support reusing the same build on different URLs. It's a limitation caused by how we approach bundling. I think it's best for single page apps: most of them wouldn't work on arbitrary URLs anyway, and this tool is meant for single page apps. So if you want to serve from multiple URLs you'd need to do multiple builds. |
3 participants
User story:
I want to publish my app on, for example, Github Pages and I want to leave PUBLIC_URL as a default due to possibility of change of the endpoint url or share the build between several endpoints.