Closed
Conversation
facebook-github-bot added GH Review: review-needed CLA Signed 
Contributor
| LGTM -- @kassens can you summon the bot to import this? |
local-cli/bundle.js Outdated
Contributor
There was a problem hiding this comment.
This file is not synced internally. Can you submit a different pull request for this one?
Member Author
| @facebook-github-bot import |
The `react.displayName` transform was added in 93b9329. That diff missed to update the `.babelrc` where the comment says it should stay in sync (I'm not sure where it's used though). I added a comment in the other direction so this can be prevented in the future. I also updated the `cacheVersion` so we actually transform the code again to add the missing displayName properties to unchanged components.
Contributor
| Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/160433834297838/int_phab to review. |
kassens added a commit to kassens/react-native that referenced this pull request Sep 23, 2015
As requested by @vjeux, this moves the change to this file to a separate PR. For more info see facebook#2905.
ghost closed this in MattFoley pushed a commit to skillz/react-native that referenced this pull request Nov 9, 2015
As requested by @vjeux, this moves the change to this file to a separate PR. For more info see facebook#2905.
MattFoley pushed a commit to skillz/react-native that referenced this pull request Nov 9, 2015
Summary: The `react.displayName` transform was added in 93b9329. That diff missed to update the `.babelrc` where the comment says it should stay in sync (I'm not sure where it's used though). I added a comment in the other direction so this can be prevented in the future. I also updated the `cacheVersion` so we actually transform the code again to add the missing displayName properties to unchanged components. Closes facebook#2905 Reviewed By: @vjeux Differential Revision: D2473447 Pulled By: @kassens
cpojer pushed a commit to facebook/metro that referenced this pull request Jan 26, 2017
Summary: The `react.displayName` transform was added in 93b9329b758cde3e921b26e11ba91d9700d2a06d. That diff missed to update the `.babelrc` where the comment says it should stay in sync (I'm not sure where it's used though). I added a comment in the other direction so this can be prevented in the future. I also updated the `cacheVersion` so we actually transform the code again to add the missing displayName properties to unchanged components. Closes facebook/react-native#2905 Reviewed By: @vjeux Differential Revision: D2473447 Pulled By: @kassens
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
react.displayNametransform was added in 93b9329.That diff missed to update the
.babelrcwhere the comment says it should stayin sync (I'm not sure where it's used though). I added a comment in the other
direction so this can be prevented in the future.
I also updated the
cacheVersionso we actually transform the code again to addthe missing displayName properties to unchanged components.