Add more specific error messages for bad callback in setState, replaceState, and ReactDOM.render #6310
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This builds on #5193 and introduces an important, in my opinion, detail (constructor function name) that makes issues like #6306 more easily identified.
Additionally, this removes the mention of methods that have been removed (
setPropsandreplaceProps).When using
onClick={this.setState.bind(this, nextState)}by mistake, the error message says:0.14
After #5193
After this PR
Why?
setProps,replaceProps).enqueueCallback()is an implementation detail and is confusing to the user.SyntheticMouseEvent) makes it much more clear why you get issues like 'Bind' will result in errors in onClick handler #6306.ReactDOM.render()instead of just failing with a TypeError.