Skip to content

[eslint-plugin] Animation shorthand expansion #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhakat wants to merge 3 commits into
base: main
Choose a base branch
from
+496 −0
Open

[eslint-plugin] Animation shorthand expansion #1538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4913dd
[eslint-plugin] Add animation shorthand expansion to stylex-valid-sho…
Mar 19, 2026
d4a6564
[eslint-plugin] Harden animation shorthand none handling
Mar 20, 2026
7a1ae9a
[eslint-plugin] Fix Flow null refinement for animation fillMode
Mar 20, 2026
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
320 changes: 320 additions & 0 deletions packages/@stylexjs/eslint-plugin/__tests__/stylex-valid-shorthands-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1752,5 +1752,325 @@ eslintTester.run('stylex-valid-shorthands', rule.default, {
},
],
},
// animation: duration + name
{
code: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animation: 'slidein 3s',
},
});
`,
output: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animationDuration: '3s',
animationName: 'slidein',
},
});
`,
errors: [
{
message:
'Property shorthands using multiple values like "animation: slidein 3s" are not supported in StyleX. Separate into individual properties.',
},
],
},
// animation: duration + timing + name
{
code: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animation: 'slidein 3s ease-in',
},
});
`,
output: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animationDuration: '3s',
animationTimingFunction: 'ease-in',
animationName: 'slidein',
},
});
`,
errors: [
{
message:
'Property shorthands using multiple values like "animation: slidein 3s ease-in" are not supported in StyleX. Separate into individual properties.',
},
],
},
// animation: duration + delay (two time values)
{
code: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animation: 'slidein 3s 1s',
},
});
`,
output: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animationDuration: '3s',
animationDelay: '1s',
animationName: 'slidein',
},
});
`,
errors: [
{
message:
'Property shorthands using multiple values like "animation: slidein 3s 1s" are not supported in StyleX. Separate into individual properties.',
},
],
},
// animation: full shorthand with all properties
{
code: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animation: '3s ease-in 1s 2 reverse both paused slidein',
},
});
`,
output: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animationDuration: '3s',
animationTimingFunction: 'ease-in',
animationDelay: '1s',
animationIterationCount: '2',
animationDirection: 'reverse',
animationFillMode: 'both',
animationPlayState: 'paused',
animationName: 'slidein',
},
});
`,
errors: [
{
message:
'Property shorthands using multiple values like "animation: 3s ease-in 1s 2 reverse both paused slidein" are not supported in StyleX. Separate into individual properties.',
},
],
},
// animation: cubic-bezier timing function
{
code: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animation: 'slidein 300ms cubic-bezier(0.4, 0, 0.2, 1)',
},
});
`,
output: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animationDuration: '300ms',
animationTimingFunction: 'cubic-bezier(0.4, 0, 0.2, 1)',
animationName: 'slidein',
},
});
`,
errors: [
{
message:
'Property shorthands using multiple values like "animation: slidein 300ms cubic-bezier(0.4, 0, 0.2, 1)" are not supported in StyleX. Separate into individual properties.',
},
],
},
// animation: infinite iteration count
{
code: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animation: 'spin 1s linear infinite',
},
});
`,
output: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animationDuration: '1s',
animationTimingFunction: 'linear',
animationIterationCount: 'infinite',
animationName: 'spin',
},
});
`,
errors: [
{
message:
'Property shorthands using multiple values like "animation: spin 1s linear infinite" are not supported in StyleX. Separate into individual properties.',
},
],
},
// animation: with !important
{
options: [{ allowImportant: true }],
code: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animation: 'slidein 2s ease !important',
},
});
`,
output: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animationDuration: '2s !important',
animationTimingFunction: 'ease !important',
animationName: 'slidein !important',
},
});
`,
errors: [
{
message:
'Property shorthands using multiple values like "animation: slidein 2s ease !important" are not supported in StyleX. Separate into individual properties.',
},
],
},
// animation: comma-separated multi-animation is CANNOT_FIX
{
code: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animation: 'slidein 3s, fadeout 2s',
},
});
`,
errors: [
{
message:
'Property shorthands using multiple values like "animation: slidein 3s, fadeout 2s" are not supported in StyleX. Separate into individual properties.',
},
],
},
// animation: iteration count before duration
{
code: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animation: '2 3s slidein',
},
});
`,
output: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animationDuration: '3s',
animationIterationCount: '2',
animationName: 'slidein',
},
});
`,
errors: [
{
message:
'Property shorthands using multiple values like "animation: 2 3s slidein" are not supported in StyleX. Separate into individual properties.',
},
],
},
// animation: ambiguous "none" emits both fill-mode and animation-name
{
code: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animation: '1s none',
},
});
`,
output: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animationDuration: '1s',
animationFillMode: 'none',
Copy link
Member

@mellyeliu mellyeliu Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm don't think we need animationFillMode here - let's refactor and remove
animationName: 'none',
},
});
`,
errors: [
{
message:
'Property shorthands using multiple values like "animation: 1s none" are not supported in StyleX. Separate into individual properties.',
},
],
},
// animation: named keyframe with explicit none fill-mode
{
code: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animation: 'fadein 1s none',
},
});
`,
output: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animationDuration: '1s',
animationFillMode: 'none',
animationName: 'fadein',
},
});
`,
errors: [
{
message:
'Property shorthands using multiple values like "animation: fadein 1s none" are not supported in StyleX. Separate into individual properties.',
},
],
},
// animation: alternate-reverse direction
{
code: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animation: 'bounce 1s alternate-reverse',
},
});
`,
output: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
animationDuration: '1s',
animationDirection: 'alternate-reverse',
animationName: 'bounce',
},
});
`,
errors: [
{
message:
'Property shorthands using multiple values like "animation: bounce 1s alternate-reverse" are not supported in StyleX. Separate into individual properties.',
},
],
},
],
});
1 change: 1 addition & 0 deletions packages/@stylexjs/eslint-plugin/src/stylex-valid-shorthands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ const shorthandAliases: $ReadOnly<{
gridRow: createSpecificTransformer('grid-row'),
gridTemplate: createSpecificTransformer('grid-template'),
outline: createSpecificTransformer('outline'),
animation: createSpecificTransformer('animation'),
margin: createDirectionalTransformer('margin', 'Block', 'Inline'),
padding: createDirectionalTransformer('padding', 'Block', 'Inline'),
marginBlock: createBlockInlineTransformer('margin', 'Block'),
Expand Down
Loading
Loading