Skip to content

Fix: Fixed NullReferenceException with DefaultDestinationFolderPath #13662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 7, 2023
Merged

Fix: Fixed NullReferenceException with DefaultDestinationFolderPath #13662

merged 5 commits into from
Nov 7, 2023

Conversation

@yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 5, 2023 •
edited
Loading

Resolved / Related Issues
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Nov 5, 2023
hishitetsu
hishitetsu reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to consider the case where SlimContentPage is null.
@yaira2
Copy link
Member Author

yaira2 commented Nov 6, 2023

In DecompressArchiveDialogViewModel?
@hishitetsu
Copy link
Member

hishitetsu commented Nov 6, 2023

Here, for example.

Files/src/Files.App/Utils/Archives/DecompressHelper.cs

Line 211 in f5b10a8

foreach (var selectedItem in associatedInstance.SlimContentPage.SelectedItems)

@yaira2
Copy link
Member Author

yaira2 commented Nov 6, 2023

Do you think that's enough, or should I keep my other changes as well?
@hishitetsu
Copy link
Member

hishitetsu commented Nov 6, 2023 •
edited
Loading

I don't think the archive will ever be null, but it could be left for safety. However, continue would be more appropriate than return.
@yaira2 yaira2 requested a review from hishitetsu November 6, 2023 17:16
hishitetsu
hishitetsu reviewed Nov 7, 2023
View reviewed changes
yaira2 and others added 2 commits November 6, 2023 21:27
@yaira2 @hishitetsu
Update src/Files.App/Utils/Archives/DecompressHelper.cs
8a7bd64 
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
@yaira2 @hishitetsu
Update src/Files.App/Utils/Archives/DecompressHelper.cs
1efa729 
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 7, 2023
@yaira2 yaira2 merged commit 93b1566 into main Nov 7, 2023
@yaira2 yaira2 deleted the ya/DefaultDestinationFolderPath- branch November 7, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

3 participants

@yaira2 @hishitetsu