Skip to content

Conversation

@hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Feb 9, 2024

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Files.App.Actions InvertSelectionAction.get_IsExecutable () ABI.System.Windows.Input.ICommand Vftbl.Do_Abi_CanExecute_2 (IntPtr thisPtr, IntPtr parameter, Byte* result) WinRT ExceptionHelpers.<ThrowExceptionForHR>g__Throw|39_0 (Int32 hr) ABI.System.EventHandler NativeDelegateWrapper.Invoke (Object sender, EventArgs args) CommunityToolkit.Mvvm.ComponentModel ObservableObject.SetProperty[T] (T& field, T newValue, String propertyName) Files.App.Data.Contexts ContentPageContext.UpdatePageType () CommunityToolkit.Mvvm.ComponentModel ObservableObject.SetProperty[T] (T& field, T newValue, String propertyName) Files.App.Data.Models CurrentInstanceViewModel.set_IsPageTypeNotHome (Boolean value) Files.App.Views.Layouts BaseLayoutPage.OnNavigatedTo (NavigationEventArgs e) System.Threading.Tasks.Task <>c.<ThrowAsync>b__128_0 (Object state) Microsoft.UI.Dispatching.DispatcherQueueSynchronizationContext <>c__DisplayClass2_0.<Post>b__0 () WinRT ExceptionHelpers.<ThrowExceptionForHR>g__Throw|39_0 (Int32 hr) ABI.Windows.ApplicationModel.Core IUnhandledErrorMethods.Propagate (IObjectReference _obj) Microsoft.AppCenter.Utils ApplicationLifecycleHelperWinUI.<ctor>b__0_3 (Object sender, UnhandledErrorDetectedEventArgs eventArgs) 

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 9, 2024
@yaira2 yaira2 merged commit b7d2f18 into files-community:main Feb 9, 2024
@hishitetsu hishitetsu deleted the hishitetsu-patch-1 branch February 10, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

2 participants