Skip to content

Code Quality: Remove thumbnail cache to simplify logic and improve performance #14871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 3, 2024
Merged

Code Quality: Remove thumbnail cache to simplify logic and improve performance #14871

merged 12 commits into from
Mar 3, 2024

Conversation

@yaira2
Copy link
Member

@yaira2 yaira2 commented Feb 29, 2024

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.
@yaira2 yaira2 changed the title Ya/icons op Code Quality: Only call thumbnail loop for cloud files Feb 29, 2024
hishitetsu
hishitetsu reviewed Mar 1, 2024
View reviewed changes
hishitetsu
hishitetsu reviewed Mar 1, 2024
View reviewed changes
hishitetsu
hishitetsu approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in terms of code quality
yaira2 and others added 8 commits March 1, 2024 11:25
@yaira2
Create single var getIconOnly
5c57038
@yaira2
Part 2
0ffd98f
@yaira2
Update ItemViewModel.cs
a837363
@yaira2
Part 2
6fc79ba
@yaira2
Add comments
b19ee13
@yaira2 @hishitetsu
Update src/Files.App/Data/Models/ItemViewModel.cs
a976bf7 
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
@yaira2 @hishitetsu
Update src/Files.App/Data/Models/ItemViewModel.cs
11684c5 
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
@yaira2 @hishitetsu
Update src/Files.App/Data/Models/ItemViewModel.cs
5ef5215 
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
@yaira2 yaira2 force-pushed the ya/IconsOp branch 2 times, most recently from b686e6d to 68bd772 Compare March 1, 2024 18:33
@yaira2 yaira2 changed the title Code Quality: Only call thumbnail loop for cloud files Code Quality: Remove thumbnail cache to simplify logic and improve performance Mar 3, 2024
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Mar 3, 2024
hishitetsu
hishitetsu reviewed Mar 3, 2024
View reviewed changes
@yaira2 @hishitetsu
Update src/Files.App/Data/Models/ItemViewModel.cs
6510b2c 
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Mar 3, 2024
@yaira2 yaira2 merged commit 4f4cd89 into main Mar 3, 2024
@yaira2 yaira2 deleted the ya/IconsOp branch March 3, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

3 participants

@yaira2 @hishitetsu