Skip to content

Code Quality: Convert into await using statement or declaration #16694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 26, 2025
Merged

Code Quality: Convert into await using statement or declaration #16694

merged 2 commits into from
Jan 26, 2025

Conversation

@andreistaravoitau
Copy link
Contributor

@andreistaravoitau andreistaravoitau commented Jan 9, 2025

Resolved / Related Issues

Steps used to test these changes

  1. Opened Files with the updated code.
  2. Verified that resources are disposed of asynchronously without blocking the UI.
  3. Tested all affected scenarios for stability, including:
  • Opening and closing files
  • Performing file operations (e.g., move, copy, delete)
  • Handling zip files.
@yaira2 yaira2 changed the title Convert into await using statement or declaration Code Quality: Convert into await using statement or declaration Jan 9, 2025
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Jan 9, 2025
@yaira2 yaira2 requested a review from gave92 January 13, 2025 23:29
Lamparter
Lamparter reviewed Jan 17, 2025
View reviewed changes
@yaira2 yaira2 requested a review from 0x5bfa January 23, 2025 16:41
@0x5bfa
Copy link
Member

0x5bfa commented Jan 23, 2025

Code wise, LGTM.
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Jan 26, 2025
@yaira2 yaira2 merged commit 02c2320 into files-community:main Jan 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

5 participants

@andreistaravoitau @0x5bfa @gave92 @Lamparter @yaira2