Skip to content

fix: equality comparison for semantic version when number of segments = max allowed segments#2794

Merged
Namyalg merged 5 commits intomasterfrom
fix-semantic-version-equality
Feb 10, 2025
Merged

fix: equality comparison for semantic version when number of segments = max allowed segments#2794
Namyalg merged 5 commits intomasterfrom
fix-semantic-version-equality

Conversation

@Namyalg
Copy link
Contributor

@Namyalg Namyalg commented Dec 2, 2024

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Testing

  • Make sure all existing tests in the repository pass after your change [Verified all existing tests pass]
  • If you fixed a bug or added a feature, add a new test to cover your code [Unit tests added]

Fixes #2793

@Namyalg Namyalg requested a review from kjelko December 2, 2024 09:56
@Namyalg Namyalg changed the title fix: equality comparison for semantic version comparison when number of segments = max allowed segments fix: equality comparison for semantic version when number of segments = max allowed segments Dec 2, 2024
Copy link
Contributor

@kjelko kjelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

@Namyalg Namyalg merged commit cb2b92f into master Feb 10, 2025
8 checks passed
@lahirumaramba lahirumaramba deleted the fix-semantic-version-equality branch February 18, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants