Skip to content

add TrackPower--tooltip-power-microwatt#5799

Merged
fatadel merged 2 commits intofirefox-devtools:mainfrom
fatadel:add-microwatt-5554
Jan 30, 2026
Merged

add TrackPower--tooltip-power-microwatt#5799
fatadel merged 2 commits intofirefox-devtools:mainfrom
fatadel:add-microwatt-5554

Conversation

@fatadel
Copy link
Contributor

@fatadel fatadel commented Jan 30, 2026

Closes #5554.

This l10n id was missing and was explicitly set to optional in #5549 (comment).

This PR puts the l10n id and makes the parameter required as before.

Before

image

Profile

After

image

Profile

(look at 560ms point of the last track)

@fatadel fatadel requested review from canova and mstange January 30, 2026 14:29
@fatadel fatadel requested a review from a team as a code owner January 30, 2026 14:29
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.65%. Comparing base (3717fbe) to head (b653e6a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@ ## main #5799 +/- ## ======================================= Coverage 85.65% 85.65% ======================================= Files 319 319 Lines 31339 31339 Branches 8634 8632 -2 ======================================= Hits 26842 26842 Misses 4066 4066 Partials 431 431 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@fatadel fatadel merged commit 3c53b1e into firefox-devtools:main Jan 30, 2026
22 checks passed
@fatadel fatadel deleted the add-microwatt-5554 branch January 30, 2026 18:53
@canova canova mentioned this pull request Feb 4, 2026
canova added a commit that referenced this pull request Feb 4, 2026
Changes: [Nazım Can Altınova] Make the range duration text white again (#5792) [Alex Thayer] Display traced values in Stack Chart view (#5363) [Nazım Can Altınova] Improve the JS traced arguments visualization in call node tooltips (#5795) [Markus Stange] Make the argument-values.json profile fixture go through profile upgrading (#5796) [Markus Stange] Add thread.usedInnerWindowIDs to the processed profile format (#5780) [fatadel] Fix context menu and hover preview z-index (#5797) [fatadel] add TrackPower--tooltip-power-microwatt (#5799) [Markus Stange] Two small test fixes (#5801) [fatadel] fix selected thread pid color in light mode (#5805) [Markus Stange] Some fixes to the profile merging code (#5802) [fatadel] fix disabled button color in dark mode (#5808) [fatadel] add comment for uptime label translation (#5806) [Nazım Can Altınova] Add a theme toggle to the home page and follow the system theme by default (#5800) [Nazım Can Altınova] 🔃 Sync: l10n -> main (Feb 4, 2025) (#5813) And huge thanks to our localizers: de: Ger de: Michael Köhler de: Nazım Can Altınova el: Jim Spentzos en-GB: Ian Neal es-CL: ravmn fy-NL: Fjoerfoks ia: Melo46 it: Francesco Lodolo [:flod] nl: Mark Heijl pt-BR: Marcelo Ghelman ru: Valery Ledovskoy sv-SE: Andreas Pettersson tr: Selim Şumlu zh-TW: Pin-guang Chen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants