[#6813] Add expanded section showing effect changes & description#6820
Open
[#6813] Add expanded section showing effect changes & description#6820
Conversation
Adds the ability to expand active effects on actor and items sheets to display a list of their changes as well as the effect's description and tags. The change rows display the key (with a human-readable name if available), the change type indicated by a symbol, and the value (displayed as tooltip instead if too long). This includes improvements to `getHumanReadableAttributeLabel` to support displaying as many active effect change keys as possible and to improve how certain keys are displayed: - Support `activities[attack]...` style keys - Support generic item keys that search through all item schemas - Improved labels within `MappingField` to include entry name Closes #6813
Contributor
Collaborator Author
How do you mean? Are these flags added to the effect created by the status condition? |
Contributor
| Yes, via preCreate hooks, and updateSource for example. |
Collaborator Author
Oh, I guess if you mean will the status effects at the bottom that normally aren't displayed as their own effects, will those list changes if present. Not currently. |
Contributor
| Yes the toggleable Conditions in the Actor's effects tab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds the ability to expand active effects on actor and items sheets to display a list of their changes as well as the effect's description and tags.
The change rows display the key (with a human-readable name if available), the change type indicated by a symbol, and the value (displayed as tooltip instead if too long).
This includes improvements to
getHumanReadableAttributeLabelto support displaying as many active effect change keys as possible and to improve how certain keys are displayed:activities[attack]...style keysMappingFieldto include entry nameCloses #6813