Remove the "::" separator from the SEPARATORS_REGEXP in searcher.js #2469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| @simon04 let me know if this change looks good. Ty! |
Contributor
| Hi, thank you for this PR. I have troubles understanding the practical benefit when not considering |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Should fix #2463
Tried searching for
std::minand was able to get good C++ documentation results.The issue was in the search query normalization process. When you searched for "std::min", the "::" (scope resolution operator in C++) was being replaced with a separator character, which prevented the search from matching C++ symbols correctly.
I removed the "::" pattern from the SEPARATORS_REGEXP regular expression in the searcher.js file. This change allows the search functionality to preserve the C++ scope resolution operator (::) when processing search queries.