Inverted length comparison in String.drop #404
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
String.dropis a safe version ofString.skip, which intends to protect a call toString.skipwith arguments which would cause an exception, and instead return an empty string.However, the comparison of the length of the input string with the number of characters to drop is inverted. When it would be safe to drop the requested number of characters from the input string,
String.dropwill instead return an empty string; and when the requested number of characters exceeds the length of the input string,String.dropwill cause the exception fromString.skip.The solution is to invert the comparison.