Fix of address already in use on udp.addMembership method#5
Merged
futomi merged 1 commit intofutomi:masterfrom Apr 9, 2020
Merged
Fix of address already in use on udp.addMembership method#5futomi merged 1 commit intofutomi:masterfrom
futomi merged 1 commit intofutomi:masterfrom
Conversation
Owner
| Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an interface, due to dhcp release time, have more than a one IPv4 the addMembership method of udp fall into an error that cause an uncatchable error that restarts the node process.
I fixed the error just add a try/catch state on row 423 of dns-sd.js
I push the fix into another branch and do a pull request into master