Disable scheduled task tracing for background tasks #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cleptric approved these changes Jan 27, 2025
cleptric changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Introduced in #968 we now trace scheduled commands. However for backgrounded command we are tracing the framework starting the child process which has no meaningful data whatsoever. I am working on a solution for this but in the meantime I think it's better to disable the feature for backgrounded tasks to prevent a "flood" of 1ms transactions showing up in Sentry like so:
(in case it isn't obvious, only the
statview:*commands are not running in the background)