Pass logger from options to TransportFactory #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ste93cry suggested changes Sep 13, 2021
simPod force-pushed the pass-logger branch 3 times, most recently from 85afe67 to dad5afb Compare ste93cry suggested changes Sep 14, 2021
Contributor
ste93cry left a comment
ste93cry left a comment There was a problem hiding this comment.
Would you mind updating the CHANGELOG too to reference this PR?
simPod force-pushed the pass-logger branch 2 times, most recently from 9adbc15 to 491daeb Compare 
ste93cry approved these changes Sep 14, 2021
Contributor
ste93cry left a comment
ste93cry left a comment There was a problem hiding this comment.
Everything looks good, thank you for the contribution 💪
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I have noticed that a transport error was being logged in https://github.com/getsentry/sentry-php/blob/bfab90c7ef921221b52b75b5108201e87f0f4661/src/Transport/HttpTransport.php#L112-L115
but there always was default NullLogger registered. So I've found that even though I set logger via
optionsit was not being passed to the Transport.This fixes it.