Fix fatal errors logged twice on Symfony 3.4 on PHP 7.3 and 7.4 #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ste93cry force-pushed the fix/fatal-error-logged-twice-on-symfony-3.4 branch from cf8f2bf to 354bf9f Compare 
Jean85 approved these changes Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
While working on improving the CI pipeline to prepare it for Symfony
6.x, I realized that two builds we don't have right now (Symfony3.4on PHP7.3and7.4) were reporting a failure in the E2E tests: it looks like on those versions of PHP the fatal errors are captured twice. Not sure why it doesn't happen on PHP7.2though...