client: use slash as name/version separator #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
this avoids weird ambiguity "XML-RPC for PHP 4.2.1" sounds like it's for PHP 4.2.1
Owner
| As you noted, this might break cases where users were crazy enough to depend on that string. |
Contributor Author
| perhaps keep the current string, and additionally add the new one |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
this avoids weird ambiguity "XML-RPC for PHP 4.2.1" sounds like it's for PHP version in question, not this library.
personally i would change whole agent to be project name "PHPXMLRPC/4.2.1" or "phpxmlrpc/4.2.1", but that might break some scenarios when useragent is matched on remote side.