Skip to content

Whitelist UnexpectedException test for all architectures and recommend libunwind in INSTALL#291

Open
hmelder wants to merge 6 commits intomasterfrom
unexpected-exp
Open

Whitelist UnexpectedException test for all architectures and recommend libunwind in INSTALL#291
hmelder wants to merge 6 commits intomasterfrom
unexpected-exp

Conversation

@hmelder
Copy link
Member

@hmelder hmelder commented Apr 26, 2024

I am undecided about whether to add a try_compile to the CMakeLists.txt to automatically use CompilerRT and libunwind if they are available. This should exclude Windows and Android.

This PR should be merged after a fix for libgcc: _Unwind_RaiseException corrupts return value is implemented in GCC.

@hmelder
Copy link
Member Author

hmelder commented Apr 26, 2024

On the other hand, automatic configuration is better than manually setting compile flags.

@hmelder
Copy link
Member Author

hmelder commented Apr 28, 2024

What do you think @davidchisnall?

@davidchisnall
Copy link
Member

I think this is the right thing (implicitly linking a non-default unwinded will break things for people), but I’d like CI to be green…

@hmelder
Copy link
Member Author

hmelder commented Apr 29, 2024

but I’d like CI to be green…

We can use CompilerRT + libunwind in the CI

@hmelder
Copy link
Member Author

hmelder commented Apr 29, 2024

I guess finding prebuild libunwind cross builds for ubuntu might be a bit difficult

@hmelder
Copy link
Member Author

hmelder commented Jul 23, 2024

Seems like the GCC patch has not arrived in 24.04LTS :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants