Skip to content

Conversation

@AndreasKl
Copy link
Contributor

Enable consumers to provide an existing *sql.DB with the option to close the connection without closing the underlying *sql.DB instance.

See the following thread for reference and how it was implemented for MySQL:
#578
#583

@coveralls
Copy link

coveralls commented Nov 29, 2021

Pull Request Test Coverage Report for Build 1875336797

  • 20 of 24 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 57.854%

Changes Missing Coverage Covered Lines Changed/Added Lines %
database/postgres/postgres.go 20 24 83.33%
Totals Coverage Status
Change from base Build 1821224966: 0.05%
Covered Lines: 3742
Relevant Lines: 6468

💛 - Coveralls
@AndreasKl
Copy link
Contributor Author

@dhui Hi, can I improve the PR to get the change merged?

@c0olix
Copy link

c0olix commented Jan 3, 2022

+1 for this feature.

@dhui dhui merged commit 57aead3 into golang-migrate:master Feb 24, 2022
@dhui
Copy link
Member

dhui commented Feb 24, 2022

Thanks for the PR and your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants