Open
Conversation
| ✅ All contributors have signed the CLA. |
Author
| I have read the CLA Document and I hereby sign the CLA |
vigoo reviewed Mar 17, 2026
| let client = self | ||
| .get_client(key) | ||
| .or_else(|| { | ||
| let _ = futures::executor::block_on(self.create(key.address.as_str(), worker_id)); |
Contributor
There was a problem hiding this comment.
Don't do block_on - it's going to block the thread the the current tokio task is running on until create completes. As or_else can't take an async closure, I'd suggest creating a helper function for this that matches on the result manually.
vigoo reviewed Mar 17, 2026
| DbValue::Uuid(v) => SerializableDbValueNode::Uuid(v), | ||
| DbValue::Date(ms) => { | ||
| let dt = Utc.timestamp_millis_opt(ms).single().unwrap_or_default(); | ||
| SerializableDbValueNode::Timestamp(dt.naive_utc()) |
Contributor
There was a problem hiding this comment.
If ignite's DATE value is not really a timestamp but just a year/month/day then we may want to use SerializableDbValueNode::Date instead
vigoo reviewed Mar 17, 2026
| Self { | ||
| ordinal: value.ordinal as u64, | ||
| name: value.name, | ||
| db_type_name: "unknown".to_string(), |
Contributor
There was a problem hiding this comment.
Is it possible to know the type somehow here?
Contributor
| To fix the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add rdbms support for Apache Ignite v2