feat: allow the runner to automatically create a session if AutoCreateSession is enabled.#622
Conversation
…teSession` is enabled.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces an AutoCreateSession option to the Runner. The implementation correctly adds the configuration and a new field to the Runner struct. The core logic in Runner.Run is updated to create a session if it doesn't exist when this option is enabled. The accompanying test TestRunner_AutoCreateSession is well-written and covers the expected scenarios.
I have two points of feedback. First, a minor style inconsistency in a comment. Second, and more importantly, a potential issue in the error handling logic for session creation. The current implementation could attempt to create a session on any error from sessionService.Get, not just when a session is not found, which could mask other problems. Please see my detailed comments.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This change introduces an AutoCreateSession configuration option to the Runner. When enabled, the Runner.Run method will automatically create a new session if the requested session ID is not found, instead of returning an error. This aligns the behavior with the Python ADK. Also added TestRunner_AutoCreateSession test to verify expected behavior across four scenarios.