refactor: update memory req/resp names#671
Merged
dpasiukevich merged 1 commit intogoogle:mainfrom Mar 20, 2026
Merged
Conversation
BREAKING CHANGE
hyangah approved these changes Mar 20, 2026
Contributor
hyangah left a comment
hyangah left a comment There was a problem hiding this comment.
Update the PR message to explain why req/resp cannot be renamed to match the method name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
We decided to keep the new name for the memory service method:
SearchMemoryso it's a consistent naming across ADKs.While for the req/resp we already have to keep the original naming
memory.SearchRequestandmemory.SearchResponse. These structs are used in ToolContext and many users already rely and use them (e.g in their tests), so this is a large breaking change, not worth it.