This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Fix lessons data pump to correctly send lesson_id instead of unit_id#3
Open
ianibo wants to merge 1 commit intogoogle:masterfrom
Open
Fix lessons data pump to correctly send lesson_id instead of unit_id#3ianibo wants to merge 1 commit intogoogle:masterfrom
ianibo wants to merge 1 commit intogoogle:masterfrom
Conversation
…_id for the lesson_id property. Verified working in citizen math deployment and corresponding BigQuery instance
DavidLemayian referenced this pull request in CodeForAfrica-ARCHIVE/coursebuilder-core Aug 12, 2017
Feedback and partners page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the lessons data pump, GCB sends the unit_id where lesson_id should appear, making it impossible to match lesson rows with the corresponding data in student_aggregate. This commit replaces it with lesson_id.