Skip to content

fix: preserve new lines #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 8, 2023
Merged

fix: preserve new lines #1721

merged 8 commits into from
Aug 8, 2023

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Aug 4, 2023

Fixes #1693 🦕
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 4, 2023
@parthea parthea changed the title fix: preserve new lines in lists fix: preserve new lines Aug 4, 2023
@parthea parthea marked this pull request as ready for review August 4, 2023 19:52
@parthea parthea requested a review from a team as a code owner August 4, 2023 19:52
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 4, 2023
@parthea parthea requested a review from ohmayr August 4, 2023 20:34
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Aug 8, 2023
@parthea
fix docs build. Fix proposed upstream here: googleapis/gapic-generato…
28e6857 
…r-python#1721
parthea added a commit to googleapis/python-network-services that referenced this pull request Aug 8, 2023
@parthea
fix docs build. Fix proposed upstream here: googleapis/gapic-generato…
ed74359 
…r-python#1721
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 8, 2023
@parthea parthea merged commit baa136f into main Aug 8, 2023
@parthea parthea deleted the preserve-new-line-lists branch August 8, 2023 23:16
@release-please release-please bot mentioned this pull request Aug 8, 2023
Merged
parthea added a commit to googleapis/python-network-services that referenced this pull request Aug 9, 2023
@gcf-owl-bot @parthea
docs: Minor formatting (#88)
4ebd038 
* chore: Update gapic-generator-python to v1.11.4 PiperOrigin-RevId: 547897126 Source-Link: googleapis/googleapis@c09c75e Source-Link: https://github.com/googleapis/googleapis-gen/commit/45e0ec4343517cd0aa66b5ca64232a1802c2f945 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDVlMGVjNDM0MzUxN2NkMGFhNjZiNWNhNjQyMzJhMTgwMmMyZjk0NSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: Minor formatting docs: Add clarifications for fields in `RouteAction` message PiperOrigin-RevId: 553528820 Source-Link: googleapis/googleapis@0d9d568 Source-Link: https://github.com/googleapis/googleapis-gen/commit/104e9c5902f64afd75bdb6507a7702eaa7b43803 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTA0ZTljNTkwMmY2NGFmZDc1YmRiNjUwN2E3NzAyZWFhN2I0MzgwMyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix docs build. Fix proposed upstream here: googleapis/gapic-generator-python#1721 --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit to googleapis/python-datastore that referenced this pull request Aug 9, 2023
@parthea
apply docs fix from googleapis/gapic-generator-python#1721
0fb1da2
parthea added a commit to googleapis/python-video-live-stream that referenced this pull request Aug 9, 2023
@parthea
apply docs fix from googleapis/gapic-generator-python#1721
b6d9cf4
parthea added a commit to googleapis/python-datastore that referenced this pull request Aug 9, 2023
@gcf-owl-bot @parthea
feat: publish proto definitions for SUM/AVG in Datastore (#456)
cfcd0c2 
* chore: Update gapic-generator-python to v1.11.3 PiperOrigin-RevId: 546899192 Source-Link: googleapis/googleapis@e6b1691 Source-Link: googleapis/googleapis-gen@0b3917c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIzOTE3YzQyMWNiZGE3ZmNiNjcwOTJlMTZjMzNmM2VhNDZmNGJjNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore(python): Add `warehouse-package-name` for google/datastore/admin/v1 PiperOrigin-RevId: 551158666 Source-Link: googleapis/googleapis@5096eae Source-Link: googleapis/googleapis-gen@a0e6a6c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTBlNmE2Y2EzNjJjODUyMWFiMzAxNDA4ZGIzODlkZDgyMzVjYTA3MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: Specify limit for `properties` in `Index` message in Datastore Admin API docs: Minor formatting in Datastore Admin API PiperOrigin-RevId: 551819875 Source-Link: googleapis/googleapis@3db8b01 Source-Link: googleapis/googleapis-gen@7ebf113 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2ViZjExMzc2MzliOTM2MTNlNmE2MjA2NjU0YTViYThmMjFlOTMyMSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: publish proto definitions for SUM/AVG in Datastore PiperOrigin-RevId: 552847139 Source-Link: googleapis/googleapis@6148e5b Source-Link: googleapis/googleapis-gen@96be51b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTZiZTUxYjk5NTA0N2JmZGVmNDgyNTE3ODUzOWUyMzg1ODMxMDFhOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * apply docs fix from googleapis/gapic-generator-python#1721 --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit to googleapis/python-video-live-stream that referenced this pull request Aug 9, 2023
@gcf-owl-bot @parthea
feat: added support for slate events which allow users to create and …
825eedf 
…insert a slate into a live stream to replace the main live stream content (#171) * chore: Update gapic-generator-python to v1.11.3 PiperOrigin-RevId: 546899192 Source-Link: googleapis/googleapis@e6b1691 Source-Link: https://github.com/googleapis/googleapis-gen/commit/0b3917c421cbda7fcb67092e16c33f3ea46f4bc7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIzOTE3YzQyMWNiZGE3ZmNiNjcwOTJlMTZjMzNmM2VhNDZmNGJjNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Update gapic-generator-python to v1.11.4 PiperOrigin-RevId: 547897126 Source-Link: googleapis/googleapis@c09c75e Source-Link: https://github.com/googleapis/googleapis-gen/commit/45e0ec4343517cd0aa66b5ca64232a1802c2f945 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDVlMGVjNDM0MzUxN2NkMGFhNjZiNWNhNjQyMzJhMTgwMmMyZjk0NSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: added support for slate events which allow users to create and insert a slate into a live stream to replace the main live stream content feat: added a new asset resource which can be used as the content of slate events feat: added a new pool resource for protecting input endpoints within a VPC Service Controls perimeter PiperOrigin-RevId: 549682971 Source-Link: googleapis/googleapis@e43e3d6 Source-Link: https://github.com/googleapis/googleapis-gen/commit/47b82671ba10862a68df4c11a978131c2c92124c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDdiODI2NzFiYTEwODYyYTY4ZGY0YzExYTk3ODEzMWMyYzkyMTI0YyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * apply docs fix from googleapis/gapic-generator-python#1721 --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit to googleapis/python-datastore that referenced this pull request Aug 28, 2023
@parthea
apply docs fix from googleapis/gapic-generator-python#1721
ce13196
parthea added a commit to googleapis/python-datastore that referenced this pull request Aug 28, 2023
@gcf-owl-bot @parthea
docs: Update property requirement specifications (#470)
795ce81 
* docs: Update property requirement specifications PiperOrigin-RevId: 557861399 Source-Link: googleapis/googleapis@3303b93 Source-Link: googleapis/googleapis-gen@fb0d0a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmIwZDBhNDUzODVlYjBiZTU4NDIxMTFhZjc5YWY1ZDcxOWQzMjE2OCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * apply docs fix from googleapis/gapic-generator-python#1721 --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Sep 14, 2023
@gcf-owl-bot @parthea
docs: Minor formatting (#88)
9fa904d 
* chore: Update gapic-generator-python to v1.11.4 PiperOrigin-RevId: 547897126 Source-Link: googleapis/googleapis@c09c75e Source-Link: googleapis/googleapis-gen@45e0ec4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDVlMGVjNDM0MzUxN2NkMGFhNjZiNWNhNjQyMzJhMTgwMmMyZjk0NSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: Minor formatting docs: Add clarifications for fields in `RouteAction` message PiperOrigin-RevId: 553528820 Source-Link: googleapis/googleapis@0d9d568 Source-Link: googleapis/googleapis-gen@104e9c5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTA0ZTljNTkwMmY2NGFmZDc1YmRiNjUwN2E3NzAyZWFhN2I0MzgwMyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix docs build. Fix proposed upstream here: googleapis/gapic-generator-python#1721 --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Sep 20, 2023
@gcf-owl-bot @parthea
feat: added support for slate events which allow users to create and …
987edab 
…insert a slate into a live stream to replace the main live stream content (#171) * chore: Update gapic-generator-python to v1.11.3 PiperOrigin-RevId: 546899192 Source-Link: googleapis/googleapis@e6b1691 Source-Link: googleapis/googleapis-gen@0b3917c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIzOTE3YzQyMWNiZGE3ZmNiNjcwOTJlMTZjMzNmM2VhNDZmNGJjNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Update gapic-generator-python to v1.11.4 PiperOrigin-RevId: 547897126 Source-Link: googleapis/googleapis@c09c75e Source-Link: googleapis/googleapis-gen@45e0ec4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDVlMGVjNDM0MzUxN2NkMGFhNjZiNWNhNjQyMzJhMTgwMmMyZjk0NSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: added support for slate events which allow users to create and insert a slate into a live stream to replace the main live stream content feat: added a new asset resource which can be used as the content of slate events feat: added a new pool resource for protecting input endpoints within a VPC Service Controls perimeter PiperOrigin-RevId: 549682971 Source-Link: googleapis/googleapis@e43e3d6 Source-Link: googleapis/googleapis-gen@47b8267 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDdiODI2NzFiYTEwODYyYTY4ZGY0YzExYTk3ODEzMWMyYzkyMTI0YyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * apply docs fix from googleapis/gapic-generator-python#1721 --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Nov 24, 2025
@gcf-owl-bot @parthea
feat: publish proto definitions for SUM/AVG in Datastore (#456)
06cb089 
* chore: Update gapic-generator-python to v1.11.3 PiperOrigin-RevId: 546899192 Source-Link: googleapis/googleapis@e6b1691 Source-Link: googleapis/googleapis-gen@0b3917c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIzOTE3YzQyMWNiZGE3ZmNiNjcwOTJlMTZjMzNmM2VhNDZmNGJjNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore(python): Add `warehouse-package-name` for google/datastore/admin/v1 PiperOrigin-RevId: 551158666 Source-Link: googleapis/googleapis@5096eae Source-Link: googleapis/googleapis-gen@a0e6a6c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTBlNmE2Y2EzNjJjODUyMWFiMzAxNDA4ZGIzODlkZDgyMzVjYTA3MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: Specify limit for `properties` in `Index` message in Datastore Admin API docs: Minor formatting in Datastore Admin API PiperOrigin-RevId: 551819875 Source-Link: googleapis/googleapis@3db8b01 Source-Link: googleapis/googleapis-gen@7ebf113 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2ViZjExMzc2MzliOTM2MTNlNmE2MjA2NjU0YTViYThmMjFlOTMyMSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: publish proto definitions for SUM/AVG in Datastore PiperOrigin-RevId: 552847139 Source-Link: googleapis/googleapis@6148e5b Source-Link: googleapis/googleapis-gen@96be51b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTZiZTUxYjk5NTA0N2JmZGVmNDgyNTE3ODUzOWUyMzg1ODMxMDFhOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * apply docs fix from googleapis/gapic-generator-python#1721 --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Nov 24, 2025
@gcf-owl-bot @parthea
docs: Update property requirement specifications (#470)
80c8083 
* docs: Update property requirement specifications PiperOrigin-RevId: 557861399 Source-Link: googleapis/googleapis@3303b93 Source-Link: googleapis/googleapis-gen@fb0d0a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmIwZDBhNDUzODVlYjBiZTU4NDIxMTFhZjc5YWY1ZDcxOWQzMjE2OCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * apply docs fix from googleapis/gapic-generator-python#1721 --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

2 participants

@parthea @ohmayr