Skip to content

Conversation

@Adriman2
Copy link

Google announced it wouldn't support the searchconsole API after 31.12.2020. Changing the build allows to still use the example

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Google announced it wouldn't support the searchconsole API after 31.12.2020. Changing the build allows to use the example
@Adriman2 Adriman2 requested a review from a team as a code owner January 13, 2021 10:59
@Adriman2 Adriman2 requested a review from dinagraves January 13, 2021 10:59
@google-cla
Copy link

google-cla bot commented Jan 13, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Jan 13, 2021
@Adriman2
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 13, 2021
@Adriman2 Adriman2 changed the title updating build from 'searchconsole' to 'webmasters' Build update from 'searchconsole' to 'webmasters' Jan 13, 2021
@parthea
Copy link
Contributor

parthea commented Jan 13, 2021

Hi @Adriman2 ,

Thanks for taking the time to submit a PR! Please could you provide a link to the announcement regarding support for searchconsole API?

Based on a recent blog from the SearchConsole Blog webpage, PR #1092 was merged. For convenience, I've included a snippet from the blog below.

When building the Webmasters service object, make the following change:
X webmasters_service = build('webmasters', 'v3', http=http)
✓ webmasters_service = build('searchconsole', 'v1', http=http)
Again, there's no change in how objects behave.

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 13, 2021
@parthea
Copy link
Contributor

parthea commented Jan 13, 2021

Hi @Adriman2,
I'm going to close this pull request based on my last comment but please feel free to re-open it with more information.

@parthea parthea closed this Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

2 participants