Skip to content

Conversation

@cushon
Copy link
Contributor

@cushon cushon commented Oct 3, 2024

See go/bugpattern/ImmutableEnumChecker

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1525 ☕️

If you write sample code, please follow the samples format.

See go/bugpattern/ImmutableEnumChecker
@cushon cushon requested review from a team as code owners October 3, 2024 19:32
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 3, 2024
@cushon cushon changed the title Make some enum fields final fix: make some enum fields final Oct 3, 2024
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zhumin8 zhumin8 merged commit 8920155 into googleapis:main Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

2 participants