Skip to content

Add note about NO_GCE_CHECK to Metadata 404 Error #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2018
Merged

Add note about NO_GCE_CHECK to Metadata 404 Error #205

merged 1 commit into from
Nov 12, 2018

Conversation

@lbergelson
Copy link
Contributor

@lbergelson lbergelson commented Oct 24, 2018

Adding a note about the NO_GCE_CHECK environment variable to the 404 error when the metadata server is not contactable.

This makes the workaround to issue #204 much easier to discover.
@lbergelson
Add note about NO_GCE_CHECK to Metadata 404 Error
a8bf102 
This makes the workaround to issue googleapis#204 much easier to discover.
@lbergelson lbergelson requested a review from a team as a code owner October 24, 2018 17:02
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 24, 2018
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2018
@codecov-io
Copy link

codecov-io commented Nov 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@eb7e845). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #205 +/- ## ========================================= Coverage ? 75.84% Complexity ? 313 ========================================= Files ? 20 Lines ? 1354 Branches ? 148 ========================================= Hits ? 1027 Misses ? 254 Partials ? 73
Impacted Files Coverage Δ Complexity Δ
...m/google/auth/oauth2/ComputeEngineCredentials.java 81.42% <100%> (ø) 30 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7e845...a8bf102. Read the comment docs.
chingor13
chingor13 approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM
@chingor13 chingor13 merged commit 108df92 into googleapis:master Nov 12, 2018
This was referenced Nov 13, 2018
Closed
Merged
@lbergelson lbergelson mentioned this pull request Dec 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

5 participants

@lbergelson @codecov-io @chingor13 @googlebot @kokoro-team