Bring all disparate datetime handling into core helpers module. #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This way we can test all code-paths, just not the branch where Python 2.6 is active.
Using a method to convert to microseconds (which handles both naive datetime objects and ones with timezones other than UTC) and then converts them to microseconds. All consumers then convert to the desired granularity.
Also making it require a float (or int) instead of bailing out for NoneType. Changing the use of the method in bigquery to not pass potentially null values and to multiply by 1000.0 (convert from millis to micros). Also updating micros -> datetime conversion in datastore to use the newly converted method.
googlebot added the cla: yes 
gcloud/_helpers.py Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
| Other than the one quibble, LGTM |
Contributor Author
| Addressed |
dhermes added a commit that referenced this pull request Aug 12, 2015
Bring all disparate datetime handling into core helpers module.
This was referenced Aug 12, 2015
gcf-owl-bot bot added a commit that referenced this pull request Jun 3, 2025
Source-Link: googleapis/googleapis@9bc0840 Source-Link: googleapis/googleapis-gen@ca76eba Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUtdjFiZXRhLy5Pd2xCb3QueWFtbCIsImgiOiJjYTc2ZWJhZjE1MjgyODZlYTE4MmU4YTZiMjc4ZTc3ODIzOTE4YzlkIn0=
vchudnov-g pushed a commit that referenced this pull request Jun 4, 2025
…to revision 20250601 (#1051) (#13971) Source-Link: googleapis/googleapis@9bc0840 Source-Link: googleapis/googleapis-gen@ca76eba Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUtdjFiZXRhLy5Pd2xCb3QueWFtbCIsImgiOiJjYTc2ZWJhZjE1MjgyODZlYTE4MmU4YTZiMjc4ZTc3ODIzOTE4YzlkIn0= --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Merged
vchudnov-g pushed a commit that referenced this pull request Jun 5, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>google-cloud-compute-v1beta: 0.1.2</summary> ## [0.1.2](google-cloud-compute-v1beta-v0.1.1...google-cloud-compute-v1beta-v0.1.2) (2025-06-05) ### Features * [google-cloud-compute-v1beta] Update Compute Engine v1beta API to revision 20250601 ([#1051](#1051)) ([#13971](#13971)) ([70d5e39](70d5e39)) </details> <details><summary>google-cloud-dataproc: 5.19.0</summary> ## [5.19.0](google-cloud-dataproc-v5.18.1...google-cloud-dataproc-v5.19.0) (2025-06-05) ### Features * [google-cloud-dataproc] add scenarios AUTO/NONE to autotuning config ([#13969](#13969)) ([134af69](134af69)) </details> <details><summary>google-cloud-discoveryengine: 0.13.9</summary> ## [0.13.9](google-cloud-discoveryengine-v0.13.8...google-cloud-discoveryengine-v0.13.9) (2025-06-05) ### Features * add CMEK config service ([4b5d19b](4b5d19b)) * add ConnectorRunErrorContext to error log ([4b5d19b](4b5d19b)) * add custom search operators for Workspace search ([4b5d19b](4b5d19b)) * add HealthcareFhirConfig to FHIR data store ([4b5d19b](4b5d19b)) * add identity mapping service ([4b5d19b](4b5d19b)) * add more indexing state for site search engine ([4b5d19b](4b5d19b)) * add more options for layout parser config ([4b5d19b](4b5d19b)) * add user license config service ([4b5d19b](4b5d19b)) * enable claim level score for grounding ([4b5d19b](4b5d19b)) * support ACL data store and document ([4b5d19b](4b5d19b)) * support media recommendation engine ([4b5d19b](4b5d19b)) * support structured content for chunk ([4b5d19b](4b5d19b)) ### Documentation * keep the API doc up-to-date with recent changes ([4b5d19b](4b5d19b)) </details> <details><summary>google-cloud-lustre: 0.1.1</summary> ## [0.1.1](google-cloud-lustre-v0.1.0...google-cloud-lustre-v0.1.1) (2025-06-05) ### Bug Fixes * Changed field behavior for an existing field per_unit_storage_throughput. It is now required ([b60fef3](b60fef3)) ### Documentation * expand on and update various comments ([b60fef3](b60fef3)) </details> <details><summary>google-cloud-secret-manager: 2.24.0</summary> ## [2.24.0](google-cloud-secret-manager-v2.23.3...google-cloud-secret-manager-v2.24.0) (2025-06-05) ### Features * [google-cloud-secret-manager] update secret manager protos for tags ([#13976](#13976)) ([998c300](998c300)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 8, 2025
feat: add google/cloud/compute/v1beta (#1033) * build: implement matrix strategy for DIREGAPIC action * build: add alpha compute files * build: Include API channel in auto-generated PR * build: fix matrix specification * build: Have DIREGAPIC action use triggering ref or default branch * build: remove the field ScratchDisks The field was also removed purposefully in v1 * build: Add v1 proto for use as "previous proto" in conversion * build: allow all matrix jobs to complete even if some fail * build: fix location of fail-fast setting The original reference I used had it in the wrong place. Correct GitHub ref: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast * build: Disable PHP and C# builds for alpha PHP just failed. Not clear what the issue is. C# has some known failures. One of them may be the use of 3 repeated fields. * build: Disable Ruby generation This was causing some errors, too. * build: fix version in Discovery file before further processing * build: jq is supposedly pre-installed in GitHub actions * feat: Move alpha to v1alpha in all paths * build: We do need to install jq * build: Try installing without sudo sudo is not found! * build: Fix regex "version" is the last field, so it has no trailing comma * build: Fix Go imports in BUILD * build: prepare for processing beta: copy files from alpha * build: update the beta file contents to refer to beta symbols * build: configure action to run for beta as well. * build: Have each channel use its own branch for the PR * Update syntax for matrix.version in branch name * add initial versions of alpha/beta discovery docs * Revert "add initial versions of alpha/beta discovery docs" This reverts commit 489a29cdc587ff4e10fc74765acbcf99ac34d496. * stage discovery docs * remove alpha * add compute.v1beta.json which is needed for kokoro presubmit * build: add python settings * import changes from PR 1035 * clean up * clean up * Remove redundant bazelisk build --------- Co-authored-by: Victor Chudnovsky <vchudnov@google.com> chore: minor formatting build(python): add service_yaml and rest_numeric_enums configurations (#1040) feat: Update Compute Engine v1beta API to revision 20250511 (#1041) feat: Update Compute Engine v1beta API to revision 20250601 (#1051) Source-Link: googleapis/googleapis@2fc3abe Source-Link: googleapis/googleapis@24cb982 Source-Link: googleapis/googleapis@1a22026 Source-Link: googleapis/googleapis@a72e939 Source-Link: googleapis/googleapis@9bc0840
parthea pushed a commit that referenced this pull request Nov 22, 2025
parthea added a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Nov 24, 2025
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
* chore: update sys test creds * chore: update sys test creds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #1024.
This is best reviewed commit by commit. I'm happy to break it into more PRs if desired.