Skip to content

Firestore API: Fix return type name (unbalanced brackets) in pydoc. #5669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2018
Merged

Firestore API: Fix return type name (unbalanced brackets) in pydoc. #5669

merged 1 commit into from
Jul 22, 2018

Conversation

@weisi
Copy link
Contributor

@weisi weisi commented Jul 22, 2018

Currently the return type is specified as Sequence[~.firestore_v1beta1.collection.CollectionReference[. Changing to Sequence[~.firestore_v1beta1.collection.CollectionReference]. (Note the difference in the last symbol.)
@weisi weisi requested a review from theacodes as a code owner July 22, 2018 01:07
@googlebot
Copy link

googlebot commented Jul 22, 2018

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.
@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 22, 2018
@weisi
Copy link
Contributor Author

weisi commented Jul 22, 2018

(Just signed CLA from the E-mail address that made the commit.)
@googlebot
Copy link

googlebot commented Jul 22, 2018

CLAs look good, thanks!
@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 22, 2018
@tseaver tseaver merged commit 8fa7ab2 into googleapis:master Jul 22, 2018
@tseaver
Copy link
Contributor

tseaver commented Jul 22, 2018

@multiple1902 Thanks for the patch!
parthea pushed a commit that referenced this pull request Nov 24, 2025
@weisi @tseaver
Firestore API: Fix return type name in pydoc. (#5669)
d2e3ec6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants

@weisi @googlebot @tseaver