WIP: Refactor conformance tests for firestore. #6291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tseaver added testing do not merge 
googlebot added the cla: yes 
| So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
googlebot added cla: no 
This was referenced Oct 25, 2018
tseaver added a commit that referenced this pull request Oct 26, 2018
Note that this will conflict with #6291, but the master is red.
tseaver force-pushed the 6290-firestore-refactor_conformance_tests branch 2 times, most recently from f975741 to ab29550 Compare tseaver force-pushed the 6290-firestore-refactor_conformance_tests branch from f1dee59 to 1fe9959 Compare 
crwilcox approved these changes Nov 14, 2018
See #6290. Use 'pytest.mark.parametrize' to create a testcase per textproto file. Note that a *bunch* of them fail. :(
…rs including dots
…sts still fail; I don't even know what these things are yet
Normalize method order and match it in the testcase class.
Simplify / clarify implementation.
Also for '_helpers._parse_field_name'. Fix bug uncovered thereby in '_parse_field_name'.
Put it next to the only function which raises it.
Move tests to match location in file of the FUT.
Rename 'pbs_for_set' -> 'pbs_for_set_no_merge'.
Simplify: because no merge, the write message w/ update is *always* sent, even if empty before or after pulling out transforms.
Pass it as a keyword argument everywhere. Add explicit tests for the 'split_on_dots=False' cases.
tseaver force-pushed the 6290-firestore-refactor_conformance_tests branch from 1fe9959 to 581e006 Compare Contributor Author
| @crwilcox Please flip the CLA flag to allow me to merge this PR. |
crwilcox added cla: yes | A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
tseaver removed the do not merge parthea pushed a commit that referenced this pull request Nov 24, 2025
Note that this will conflict with #6291, but the master is red.
parthea pushed a commit that referenced this pull request Nov 24, 2025
Closes #6290. Breaking change from `firestore-0.30.0`: revert to merge not being an option; instead make it a bool or a list param to `set`. Use 'pytest.mark.parametrize' to create a testcase per textproto file. Blacklist conformance tests for transforms we don't yet have (ArrayDelete, ArrayUnion, and Delete) Re-import google-cloud-common testdata textprotos: discard older, renamed versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
See #6290.
Use 'pytest.mark.parametrize' to create a testcase per textproto file.
Note that a bunch of them fail. :(