Skip to content

Conversation

@yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/automl/synth.py. synthtool > Ensuring dependencies. synthtool > Pulling artman image. latest: Pulling from googleapis/artman Digest: sha256:d6c8ced606eb49973ca95d2af7c55a681acc042db0f87d135968349e7bf6dd80 Status: Image is up to date for googleapis/artman:latest synthtool > Cloning googleapis. synthtool > Running generator for google/cloud/automl/artman_automl_v1beta1.yaml. synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1. synthtool > Replaced 'metadata_type=operations_pb2.OperationMetadata' in google/cloud/automl_v1beta1/gapic/auto_ml_client.py. synthtool > No replacements made in google/cloud/automl_v1beta1/gapic/prediction_service_client.py for pattern ^\s+::, maybe replacement is not longer needed? synthtool > No replacements made in google/cloud/automl_v1beta1/gapic/auto_ml_client.py for pattern ^(\s+)(::) \s+?([^\s]), maybe replacement is not longer needed? .coveragerc .flake8 MANIFEST.in noxfile.py.j2 setup.cfg Running session blacken Creating virtualenv using python3.6 in /tmpfs/src/git/autosynth/working_repo/automl/.nox/blacken pip install --upgrade black black google tests docs reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/__init__.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/enums.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/prediction_service_client_config.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/auto_ml_client_config.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/transports/prediction_service_grpc_transport.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/transports/auto_ml_grpc_transport.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/annotation_payload_pb2_grpc.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/prediction_service_client.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/classification_pb2_grpc.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/annotation_payload_pb2.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/data_items_pb2_grpc.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/data_items_pb2.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/dataset_pb2_grpc.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/dataset_pb2.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/image_pb2_grpc.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/auto_ml_client.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/io_pb2_grpc.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/image_pb2.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/model_evaluation_pb2_grpc.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/classification_pb2.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/model_pb2_grpc.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/io_pb2.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/operations_pb2_grpc.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/model_evaluation_pb2.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/prediction_service_pb2_grpc.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/operations_pb2.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/model_pb2.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/prediction_service_pb2.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/text_pb2_grpc.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/text_pb2.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/translation_pb2_grpc.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/types.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/service_pb2_grpc.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/tests/unit/gapic/v1beta1/test_prediction_service_client_v1beta1.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/translation_pb2.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/tests/unit/gapic/v1beta1/test_auto_ml_client_v1beta1.py reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/service_pb2.py All done! ✨ 🍰 ✨ 38 files reformatted, 6 files left unchanged. Session blacken was successful. synthtool > Cleaned up 2 temporary directories. synthtool > Wrote metadata to synth.metadata. 
@yoshi-automation yoshi-automation added the api: automl Issues related to the AutoML API. label Feb 1, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 1, 2019
@tseaver tseaver added the codegen label Feb 1, 2019
@tseaver tseaver changed the title [CHANGE ME] Re-generated automl to pick up changes in the API or client library generator. [DO NOT MERGE] AutoML: borked import generation. Feb 1, 2019
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same weird / bad imports as #7224.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 1, 2019
@crwilcox
Copy link
Contributor

crwilcox commented Feb 1, 2019

@tseaver reviewed this earlier and I regen'd. There are removed imports and added imports with no usage attached. This is suspicious.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 8, 2019
@tseaver tseaver added needs work This is a pull request that needs a little love. and removed 🚨 This issue needs some love. labels Feb 19, 2019
@tseaver
Copy link
Contributor

tseaver commented Mar 4, 2019

I've just tried regenerating locally:

@tseaver
Copy link
Contributor

tseaver commented Mar 4, 2019

There are plenty of other examples of unused imports in GAPIC-generated code, so I think that it should not be a blocker here, even though I don't understand why.

@tseaver tseaver changed the title [DO NOT MERGE] AutoML: borked import generation. AutoML: sort generated classes (via synth). Mar 4, 2019
@tseaver tseaver removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. needs work This is a pull request that needs a little love. labels Mar 4, 2019
@tseaver tseaver merged commit 3a1bed3 into master Mar 4, 2019
@tseaver tseaver deleted the autosynth-automl branch March 4, 2019 19:17
parthea pushed a commit that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: automl Issues related to the AutoML API. cla: yes This human has signed the Contributor License Agreement. codegen

4 participants