Skip to content

JsonStreamWriter.Builder#setEnableConnectionPool does not obey argument passed #2083

New issue
New issue
Closed
Closed
JsonStreamWriter.Builder#setEnableConnectionPool does not obey argument passed#2083
Labels
api: bigquerystorageIssues related to the googleapis/java-bigquerystorage API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
@bastewart

Description

@bastewart
bastewart
opened on Apr 21, 2023

Code example

setEnableConnectionPool does not obey the argument passed, instead however it is called connection pooling is enabled.

You can see this in the current master branch below (introduced - presumably by mistake! - in #2048):

java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.java

Lines 322 to 325 in 4fc8286

public Builder setEnableConnectionPool(boolean enableConnectionPool) {
this.schemaAwareStreamWriterBuilder.setEnableConnectionPool(true);
return this;
}

Sorry, I have never contributed to this repo otherwise I'd just open a PR with a fix myself!

Metadata

Metadata

Assignees

No one assigned

    Labels

    api: bigquerystorageIssues related to the googleapis/java-bigquerystorage API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions