fix: fix CloudBigtableIO scan to take version and filters #3901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: l 
diegomez17 reviewed Dec 22, 2022
...-parent/bigtable-beam-import/src/main/java/com/google/cloud/bigtable/beam/TemplateUtils.java Outdated Show resolved Hide resolved
diegomez17 reviewed Dec 22, 2022
...-parent/bigtable-beam-import/src/main/java/com/google/cloud/bigtable/beam/TemplateUtils.java Outdated Show resolved Hide resolved
...parent/bigtable-hbase-beam/src/main/java/com/google/cloud/bigtable/beam/CloudBigtableIO.java Outdated Show resolved Hide resolved
...-hbase-beam/src/main/java/com/google/cloud/bigtable/beam/CloudBigtableScanConfiguration.java Outdated Show resolved Hide resolved
...-hbase-beam/src/main/java/com/google/cloud/bigtable/beam/CloudBigtableScanConfiguration.java Outdated Show resolved Hide resolved
...-hbase-beam/src/main/java/com/google/cloud/bigtable/beam/CloudBigtableScanConfiguration.java Outdated Show resolved Hide resolved
...parent/bigtable-hbase-beam/src/main/java/com/google/cloud/bigtable/beam/CloudBigtableIO.java Outdated Show resolved Hide resolved
mutianf added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run ...-hbase-beam/src/main/java/com/google/cloud/bigtable/beam/CloudBigtableScanConfiguration.java Outdated Show resolved Hide resolved
...-hbase-beam/src/main/java/com/google/cloud/bigtable/beam/CloudBigtableScanConfiguration.java Outdated Show resolved Hide resolved
...-hbase-beam/src/main/java/com/google/cloud/bigtable/beam/CloudBigtableScanConfiguration.java Outdated Show resolved Hide resolved
...-hbase-beam/src/main/java/com/google/cloud/bigtable/beam/CloudBigtableScanConfiguration.java Outdated Show resolved Hide resolved
...-hbase-beam/src/main/java/com/google/cloud/bigtable/beam/CloudBigtableScanConfiguration.java Outdated Show resolved Hide resolved
...-hbase-beam/src/main/java/com/google/cloud/bigtable/beam/CloudBigtableScanConfiguration.java Show resolved Hide resolved
mutianf added the kokoro:force-run yoshi-kokoro removed kokoro:force-run 
| Warning: This pull request is touching the following templated files:
|
igorbernstein2 approved these changes Mar 30, 2023
...-parent/bigtable-beam-import/src/main/java/com/google/cloud/bigtable/beam/TemplateUtils.java Outdated Show resolved Hide resolved
...-hbase-beam/src/main/java/com/google/cloud/bigtable/beam/CloudBigtableScanConfiguration.java Outdated Show resolved Hide resolved
...-hbase-beam/src/main/java/com/google/cloud/bigtable/beam/CloudBigtableScanConfiguration.java Outdated Show resolved Hide resolved
mutianf force-pushed the fix-io branch 2 times, most recently from 6d9a9d1 to 472690f Compare mutianf added the owlbot:run 
gcf-owl-bot bot removed the owlbot:run mutianf added automerge gcf-owl-bot bot removed the owlbot:run mutianf added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run 
gcf-merge-on-green bot removed the automerge 
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.